Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play: make the many files warning configurable #1577

Merged
merged 2 commits into from
Sep 7, 2015
Merged

play: make the many files warning configurable #1577

merged 2 commits into from
Sep 7, 2015

Conversation

nathdwek
Copy link
Member

The warning_treshold key in the play configuration defines the
minimum number of file before a warning is issued (default 100).
A zero value means no warning is ever issued.

Tests are coming. Could you just confirm this is an OK-to-have feature?

@sampsyo
Copy link
Member

sampsyo commented Aug 24, 2015

👍 Looks great.

@nathdwek
Copy link
Member Author

Actually there are no tests for beets-play yet. Do you have any specific advice on what to test and how to test it, since it's an "interoperability" plugin.

@nathdwek
Copy link
Member Author

I added documentation for this feature.

@sampsyo
Copy link
Member

sampsyo commented Aug 25, 2015

Very good question. There are two main approaches we currently use:

Do either of those seem reasonable? I'm happy to help if I can!

nath@home added 2 commits September 3, 2015 22:19
The warning_treshold key in the play configuration defines the
minimum number of file before a warning is issued (default 100).
A zero value means no warning is ever issued.

This is the first commit for this feature, and this should fully
implement it.
Added documentation for the new warning_treshold config option for
beets-play

Also made the documentation for the use_folders option more
explicit.
@sampsyo sampsyo merged commit 940dc3c into beetbox:master Sep 7, 2015
sampsyo added a commit that referenced this pull request Sep 7, 2015
play: make the many files warning configurable
sampsyo added a commit that referenced this pull request Sep 7, 2015
@nathdwek nathdwek deleted the play-warn-tresh branch November 22, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants